Fixed reentrancy in unstake

opengsn · Feb 20, 2019 · 30c62b5 · 30c62b5
1 parent bdba4ad
commit 30c62b5
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/contracts/RelayHub.sol b/contracts/RelayHub.sol
@@ -117,9 +117,8 @@ contract RelayHub is RelayHubApi {
         require(can_unstake(relay), "can_unstake failed");
         require(relays[relay].owner == msg.sender, "not owner");
         uint amount = relays[relay].stake;
-        // TODO: this is a known reentrancy vulnerability. 
-        msg.sender.transfer(relays[relay].stake);
         delete relays[relay];
+        msg.sender.transfer(amount);
         emit Unstaked(relay, amount);
     }