Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_xscale() and set_yscale() are called with arguments only if scale is logicle #290

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

castillohair
Copy link
Collaborator

Fixes #289.

@castillohair
Copy link
Collaborator Author

castillohair commented Jul 10, 2018

This branch had to be based off contour-scikit-image instead of develop because it is impossible to test without the changes therein. If #288 is merged into develop, the section "files changed" will look as intended. I recommend doing #288 first.

@JS3xton
Copy link
Contributor

JS3xton commented Jul 15, 2018

Can this script be incorporated as a unit test? (not checking the output of the plot, just asserting that the call doesn't throw an error)

@castillohair
Copy link
Collaborator Author

I think tests are outside the scope of this issue, but I opened a new issue addressing this topic more generally in #292.

@castillohair castillohair merged commit 1aae4d6 into develop Jul 17, 2018
@castillohair castillohair deleted the log-scale-fix branch July 22, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants