New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use big glob for nyc preset #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not that concerned with showNotFound TBH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks! @coreyfarrell suggested adding options: {fullTree: true}
, which makes good sense too!
happy to add that - but keep in mind it does include A LOT of extra packages not directly installed by your user, and can get confusing. |
Hmm @coreyfarrell maybe we just tell them to specify the option if the shallow option doesn't give us the answer? |
this would probably be preferable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good.
@tabrindle we are good with this, thank you so much! |
Will output like this:
Until we can add regex to npmPackages args, one big glob will have to do. No showNotFound option though :-/