Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use big glob for nyc preset #93

Merged
merged 1 commit into from Apr 15, 2019
Merged

fix: use big glob for nyc preset #93

merged 1 commit into from Apr 15, 2019

Conversation

tabrindle
Copy link
Owner

Will output like this:

  System:
    OS: macOS 10.14.2
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Memory: 324.38 MB / 16.00 GB
  Binaries:
    Node: 8.15.0 - ~/.nvm/versions/node/v8.15.0/bin/node
    Yarn: 1.12.3 - ~/.yarn/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v8.15.0/bin/npm
  npmPackages:
    @babel/core: ^7.2.2 => 7.2.2 
    @babel/plugin-proposal-optional-chaining: ^7.2.0 => 7.2.0 
    @babel/polyfill: ^7.2.5 => 7.2.5 
    @babel/preset-env: ^7.3.1 => 7.3.1 
    babel-core: 7.0.0-bridge.0 => 7.0.0-bridge.0 
    babel-eslint: ^10.0.1 => 10.0.1 
    babel-jest: 23.6.0 => 23.6.0 
    babel-loader: ^8.0.5 => 8.0.5 
    nyc: ^13.3.0 => 13.3.0 

Until we can add regex to npmPackages args, one big glob will have to do. No showNotFound option though :-/

Copy link

@coreyfarrell coreyfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that concerned with showNotFound TBH.

Copy link
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! @coreyfarrell suggested adding options: {fullTree: true}, which makes good sense too!

@tabrindle
Copy link
Owner Author

happy to add that - but keep in mind it does include A LOT of extra packages not directly installed by your user, and can get confusing.

@JaKXz
Copy link
Contributor

JaKXz commented Apr 10, 2019

Hmm @coreyfarrell maybe we just tell them to specify the option if the shallow option doesn't give us the answer?

@tabrindle
Copy link
Owner Author

this would probably be preferable. npx envinfo --preset nyc --fullTree should work just fine.

@JaKXz
Copy link
Contributor

JaKXz commented Apr 10, 2019

@coreyfarrell :shipit:?

Copy link

@coreyfarrell coreyfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good.

@JaKXz
Copy link
Contributor

JaKXz commented Apr 11, 2019

@tabrindle we are good with this, thank you so much!

@tabrindle tabrindle merged commit 424d4c5 into master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants