add ffi constructor to CommandLineApp #444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian "sp1rit" <sp1ritCS@protonmail.com>
|
For me, I created a simple wrapper within tabula-py https://github.com/chezou/tabula-py/pull/356/files#diff-08b0ea7406259cdf36400759004168d0daf3dbbc73ff7944bbc834686a4ea244R103-R115 So, I don't need this change anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening,
I've created tabula-java bindings for Rust:
tabula-rs forge & tabula on crates.io
However, as I'm using JNI rather than shelling out java, I need some way of constructing the
CommandLineAppobject. This patch adds a constructor with more primitive (array instead of List) parameters that allow creatingCommandLineAppprogrammatically (ik. this "technically" isn't a "CommandLine Application" anymore 🙃).I also needed the
CSVWriterto write newlines as LF, as at least the test files you provide are also ending with LF (otherwise my tests fail).It's been years since years since I have last written Java, but I don't think I made any major mistake :D (but if I did, please excuse me ;)).
Signed-off-by: Florian "sp1rit" sp1ritCS@protonmail.com