-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new notebook showing how to do WAP with branches #76
Conversation
This looks great to me! The only problem before I would publish this is that cherry-pick only works on one commit. You probably want to mention that where you call it out as "less elegant" (agreed!) because people may think that it would move more than one commit. Just note that it isn't a "rebase" maybe? Also, thank you for taking the time @rmoff! Good to run into you again. |
Good point, thanks @rdblue - I've updated it. |
Thank you for the work @rmoff , very helpful. I've been looking into branching and tagging capabilities of iceberg for some time now and was wondering if and how a wap approach could be used to handle duplicates. But probably this is the wrong place for such a discussion, sorry for that. |
@Fokko, can you help out here? This is failing validation but it looks good to me. |
Anything I can do here to help push this PR forward? :) |
@rmoff, the failure is this:
Looks like you just need to run the pre-commit scripts locally to fix them. Then CI will pass because it doesn't need to make any changes. |
Please run:
Commit the changes, and this PR is ready to go :) |
@Fokko thanks - have pushed a change that should fix it. |
I just ran the notebook and it looks great! Thanks for contributing @rmoff ! 👏🏻 |
Thanks, @rmoff! |
This is based on the existing
Iceberg - Integrated Audits Demo.ipynb
, and shows how to use a branch-based approach for WAP.