Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Export" broken in Firefox #261

Closed
ssorallen opened this issue Dec 29, 2018 · 4 comments
Closed

"Export" broken in Firefox #261

ssorallen opened this issue Dec 29, 2018 · 4 comments
Labels
bug firefox Issues specific to the Firefox browser

Comments

@ssorallen
Copy link
Member

ssorallen commented Dec 29, 2018

Describe the bug
Clicking the "Export" button in Firefox shows an alert but does not create a file.

To Reproduce
Steps to reproduce the behavior:

  1. Open Tab Wrangler's preferences
  2. Click on the "Options" tab
  3. Scroll and click "Export"

The console shows an exception:

TypeError: e.props.dispatch(...) is undefined

...which I believe comes from

https://github.com/tabwrangler/tabwrangler/blob/master/app/js/OptionsTab.js#L153-L163

@ssorallen ssorallen added bug firefox Issues specific to the Firefox browser labels Dec 29, 2018
@ssorallen
Copy link
Member Author

This was first reported in #104 (comment)

@ssorallen
Copy link
Member Author

@ingorichter I discovered the issue: the export function is not returning a Promise like the import is. Also, the exporting is currently being done by the background script; that works in Chrome but not in Firefox. I am going to move the actual file creation code into the popup script.

@ssorallen
Copy link
Member Author

Fixed in 3ed51b5. This will go into the next release, v6.5.0.

@ingorichter
Copy link
Contributor

Thank you for fixing the issue @ssorallen 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug firefox Issues specific to the Firefox browser
Projects
None yet
Development

No branches or pull requests

2 participants