Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Descriptions for Reader settings #51

Merged
merged 6 commits into from
Oct 1, 2019
Merged

Descriptions for Reader settings #51

merged 6 commits into from
Oct 1, 2019

Conversation

ghostbear
Copy link
Contributor

@ghostbear ghostbear commented Sep 27, 2019

TODO

  • Add images for Scale Type
  • Add images for Zoom start position
  • Add images for Background color
  • Add images for Crop border
  • Compress images

I'm open for improvements to setting descriptions.

@ghostbear
Copy link
Contributor Author

@Soitora I will drop the carousel and use expander for now

@ghostbear ghostbear changed the title [WIP] Descriptions for Reader settings Descriptions for Reader settings Sep 30, 2019
@Soitora
Copy link
Member

Soitora commented Sep 30, 2019

Sad, you didn't find any way of making it work?

@ghostbear
Copy link
Contributor Author

ghostbear commented Sep 30, 2019

I did not find a way for vue-carousel to work. But a moment ago I tried importing CSS and JavaScript via config.js which seems to work. Tried with Flickity
carousel

@Soitora
Copy link
Member

Soitora commented Sep 30, 2019

Have you been able to test its compatibility with mobile devices?

@ghostbear
Copy link
Contributor Author

Yes it works on mobile

@Soitora Soitora merged commit bc7a7a3 into tachiyomiorg:master Oct 1, 2019
@ghostbear ghostbear deleted the reader branch October 1, 2019 11:39
arkon pushed a commit that referenced this pull request Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants