Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krigga testing #1

Closed
xtonwallet opened this issue Apr 26, 2023 · 5 comments
Closed

Krigga testing #1

xtonwallet opened this issue Apr 26, 2023 · 5 comments

Comments

@xtonwallet
Copy link

xtonwallet commented Apr 26, 2023

From ton-society/grants-and-bounties#131 (comment)

While evaluating this extension, I found a few issues:

  • Autocomplete does not seem to work for some standard functions. For example, autocomplete suggests beginCell, but then fails to suggest endCell, beginParse, loadAddress or loadInt.
  • I could not get any kind of refactoring to work, not even renaming of variables or functions
  • Errors are highlighted correctly, but the detailed error description that pops up when hovering the cursor over the error contains a lot of junk, such as the source file path, line and column, and source snippet, like so:
/path/to/dir/test.tact:1:1: Trait A not found
Line 1, col 1:
> 1 | contract Test with A {
      ^~~~~~~~~~~~~~~~~~~~~~~~
  2 |     init () {

Of all this, only Trait A not found should be in the detailed error description

@logvik
Copy link
Member

logvik commented May 11, 2023

By items:

  1. Here was found some issues related to not covered by the autocomplete feature init/onbounce/receive function types. It has been fixed in the last release.
  2. This was added with the last release. Please, suggest which additional actions could be useful. For now, only rename/dump actions were introduced.
  3. This output goes directly from Tact compiler. I assume that we can't change it, because as only @ex3ndr will change this output, this extension will be broken. @ex3ndr please advise how to resolve it...

@krigga

@krigga
Copy link

krigga commented May 12, 2023

By items:

  1. The functions that I listed still were not suggested in autocomplete.
  2. Rename works, but it seems that it just replaces the whole string in the whole file, which is not how renaming should work. For example, if I have a message Test with a field amount and then I have a variable amount1 not related to that field, that will get renamed during refactoring too. The dump action works in a weird way too, seems to just insert the dump() string on the spot.
  3. I suppose this cannot be fixed without some tact compiler support, and it's also not as important, so this can be ignored.

@logvik
Copy link
Member

logvik commented May 23, 2023

  1. To the latest version has added the cascade call style.
    autocomplete_cascade
  2. The issue with rename feature has been fixed. The code action for dump command works by the new logic.
    dump

@krigga
Copy link

krigga commented May 26, 2023

Looks good! The issue can be closed

@logvik
Copy link
Member

logvik commented May 26, 2023

Thank you for this contribution!

@logvik logvik closed this as completed May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants