Bump actions/cache from 3.2.6 to 4.0.2 #1825
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [actions/cache](https://github.com/actions/cache) from 3.2.6 to 4.0.2. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3.2.6...v4.0.2) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
@mattwr18 : Pipeline is still green even that V4 is "updated minimum runner version support from node 12 -> node 20" and we are requesting node 12.2 in the env. I'm a bit confused here what is happening and what is to be expected. |
|
@soey my understanding is that the step that uses actions/cache, cache NPM dependencies, would use node v20, while our docker build and test run would use the version we specify in our .tool-versions. To be honest, I am not sure it is even working as we would want it to. I think the idea is to cache the dependencies to speed up the test runs in our CI, but all the runs I looked at reported a miss in the cache hit. Also I don't see any logic to skip the npm install step if there is a cache hit. What even happens if we run npm install with node version 12 and then try to get a cache hit using node version 20? In the examples for actions/cache, I see this note:
It seems like it might be better to remove this step. |
Bumps actions/cache from 3.2.6 to 4.0.2.
Release notes
Sourced from actions/cache's releases.
... (truncated)
Changelog
Sourced from actions/cache's changelog.
Commits
0c45773Merge pull request #1327 from cdce8p/fix-fail-on-cache-miss8a55f83Add test case for process exit3884cacBump versione29dad3Fix fail-on-cache-miss not workingab5e6d0Merge pull request #1341 from bethanyj28/main89c7d86licensed cached2c84daupdate@actions/cache37e7d4eMerge pull request #1340 from actions/bethanyj28/update-publish-flowa18323fadd release actiona2ed59dMerge pull request #1305 from actions/yacaovsnc/update_examplesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)