Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement in handling css files #23

Merged
merged 4 commits into from Oct 9, 2013
Merged

Conversation

RobinQu
Copy link
Contributor

@RobinQu RobinQu commented Oct 8, 2013

Improvements:

  • support background:url(about:blank) in css
  • support filter rules for IE, e.g. _filter:progid:DXImageTransform.Microsoft.AlphaImageLoader(src="/images/logo.png", sizingMethod="image")

@johnnyhalife
Copy link
Contributor

Does this work? What are you trying to achieve? What's about:blank on a css background?

@RobinQu
Copy link
Contributor Author

RobinQu commented Oct 9, 2013

  1. background:url(about:blank) is used as workarounds to many bugs for IE6.
  2. filter rules is only supported by IE, which common used to handle image processing, such as loading alpha channel of PNG files in IE6 or lower.

@RobinQu
Copy link
Contributor Author

RobinQu commented Oct 9, 2013

I'd like to submit a test case for this commit, however I cannot find any test suites available in this repo.
Could you tell me how to test this project?

@johnnyhalife
Copy link
Contributor

there's no test suite but I'll assume that you tested it. Of course you can
start one! =)

On Tue, Oct 8, 2013 at 11:30 PM, RobinQu notifications@github.com wrote:

I'd like to submit a test case for this commit, however I cannot find any
test suite available in this repo.
Could you tell me how to test this project?


Reply to this email directly or view it on GitHubhttps://github.com//pull/23#issuecomment-25942813
.

johnnyhalife added a commit that referenced this pull request Oct 9, 2013
enhancement in handling css files
@johnnyhalife johnnyhalife merged commit dd2a7e0 into tactivos:master Oct 9, 2013
@johnnyhalife
Copy link
Contributor

published as 0.2.7

@RobinQu
Copy link
Contributor Author

RobinQu commented Oct 22, 2013

It seems 0.2.7 is not published to NPM?

@johnnyhalife
Copy link
Contributor

sorry now it's

On Tue, Oct 22, 2013 at 3:26 AM, RobinQu notifications@github.com wrote:

It seems 0.2.7 is not published to NPM?


Reply to this email directly or view it on GitHubhttps://github.com//pull/23#issuecomment-26791892
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants