Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #19 from asifnaeem/PG93Fix
Looks good to me so I'll merge it. For future commit messages, please use one line first (80 characters or less) followed by an empty line and then a more elaborate description (where all lines are 80 chars or less). Reason being that such one liners show up in many lists where you can click on a link to get the more elaborated text.
- Loading branch information
Showing
3 changed files
with
30 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 comment
on commit 191c2fb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The submitter gives the reason for the DDRProcessor change as fixing an "illegal start of expression error" but did not mention what Java compiler or toolchain was being used. It would be good to report a bug against that compiler or toolchain, because the optional trailing comma is definitely legal in the Java Language Specification (I just checked to make sure).
Trailing comma here is explicitly legal in the Java Language Specification, see the production for ElementValueArrayInitializer in section 9.7 (of JLS3) or 9.7.1 (Jave SE 7 Edition). It's also legal to not have one. A Java toolchain that gives an error either way would seem to have a bug.