Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEWLINE pattern can fail to match #455

Closed
jcflack opened this issue Sep 2, 2023 · 1 comment
Closed

NEWLINE pattern can fail to match #455

jcflack opened this issue Sep 2, 2023 · 1 comment

Comments

@jcflack
Copy link
Contributor

jcflack commented Sep 2, 2023

The NEWLINE pattern introduced in sqlgen.Lexicals in 64b82bf can sometimes fail to match a newline, depending on what the Matcher most recently matched. It should be rewritten to be independent of the previous match (ideally while still relying on the regex engine's notion of what a newline is, rather than hardcoding a duplicate).
jcflack added a commit that referenced this issue Sep 5, 2023
@jcflack
Improve NEWLINE pattern
6a64e91 
Old one could fail depending on previous matching activity, possibly
because of the use of \G (which I should have explained better in a
comment, back when I thought I knew why I was doing it). The documented
behavior of ^ $ and \z and reluctant quantifiers make for a simpler
and more dependable version.

Addresses issue #455.
@jcflack jcflack mentioned this issue Sep 5, 2023
Merged
jcflack added a commit that referenced this issue Sep 7, 2023
@jcflack
Merge into REL1_6_STABLE these pull requests:
f2d3d29 
PR #456, #462, #463.

Addresses issue #455, and new javadoc requirements in Java 17 and 19.
@jcflack
Copy link
Contributor Author

jcflack commented Sep 19, 2023

Believed resolved in 1.6.6.

@jcflack jcflack closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcflack