Handle SETOF RECORD better in ResultSetHandle #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A function declared to return RECORD or SETOF RECORD is required by SQL to be followed by a column definition list in any query using it. If the function returns SETOF RECORD using ResultSetHandle, there is a possibility that one or more corresponding columns in the definition list and the ResultSet offered by ResultSetHandle differ in type. Let the type be cast automatically, just as it would be when using ResultSetProvider and storing each value into the output ResultSet. Also convert the SetOfRecordTest example to an annotation-style example and add an SQLAction that tests it. Addresses issue #146.
Expand the API docs to explain the interaction with the calling query's column definition list when a function is declared to return SETOF RECORD. Except for the type-casting behavior change in ResultSetHandle for issue #146, this is simply an exercise in documenting what currently happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast types as expected if the types in the supplied
ResultSetdiffer from those in the calling query's column definition list. Addresses issue #146. Adds a test and expanded API documentation.