Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Suggestions: Delay & minimal word length #11

Closed
chrisgrieser opened this issue Nov 17, 2021 · 8 comments
Closed

Setting Suggestions: Delay & minimal word length #11

chrisgrieser opened this issue Nov 17, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@chrisgrieser
Copy link

Hi, thanks for this wonderful plugin, works like a charm already!

Two reasonable settings that come to my mind are

  1. a delay before autocomplete appears.
  2. a minimal word length, I think right now it's 3?
@tadashi-aikawa
Copy link
Owner

Hi, @chrisgrieser!

a minimal word length, I think right now it's 3?

It looks good. I'll implement it.

a delay before autocomplete appears.

Would you tell me why it needs? Because it uses Obsidian EditorSuggest class which doesn't have delay options.

Best regards.

@chrisgrieser
Copy link
Author

Setting a slight delay might be useful to prevent the autocompletion suggestion popping up when you are simply slowly typing and don't need them. In that case, they block the view, which is rather distracting.

A delay would keep the aspect of automatic suggestion but only display them when you are thinking for a second

@tadashi-aikawa
Copy link
Owner

In that case, they block the view, which is rather distracting.

That makes sense!

I don't know whether it is possible or not, but I try it :)

@tadashi-aikawa tadashi-aikawa self-assigned this Nov 18, 2021
@tadashi-aikawa tadashi-aikawa added the enhancement New feature or request label Nov 18, 2021
@tadashi-aikawa
Copy link
Owner

@chrisgrieser
I have implemented this feature. Please confirm what is you expected or not.

image
2021-11-18

@chrisgrieser
Copy link
Author

Looks fine to me! :)

@tadashi-aikawa
Copy link
Owner

Released as v1.2.0 🚀

@tadashi-aikawa
Copy link
Owner

@chrisgrieser
As I type using the Various Complements plugin, I really understand that it is certainly needed, Delay option. Thanks!!

(Especially on Vim mode)

@chrisgrieser
Copy link
Author

Isn't it? :)
I code in Sublime and I indeed noticed that changing the autocomplete delay there by only 500ms made autocomplete much more useful to me, so I kind of had the feeling that this would help in Obsidian, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants