Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some keys to "Select a suggestion key" #128

Closed
tadashi-aikawa opened this issue May 12, 2022 · 6 comments
Closed

Add some keys to "Select a suggestion key" #128

tadashi-aikawa opened this issue May 12, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@tadashi-aikawa
Copy link
Owner

I'm only throwing out ideas here - some may be bad ideas

For trigger keys I would consider options of

  • None (mouse use only)
  • Shift space (if possible - that might be intuitive - space would simply exit the list shift space selects)
  • `

Originally posted by @aubreyz in #124 (reply in thread)

@tadashi-aikawa tadashi-aikawa self-assigned this May 12, 2022
@tadashi-aikawa tadashi-aikawa added the enhancement New feature or request label May 12, 2022
@Glint-Eye
Copy link

if there would be an option for "right / left arrow" for Cycling through selection, then shift + right for adding selection.
+1 for shoft + space too

@tadashi-aikawa
Copy link
Owner Author

if there would be an option for "right / left arrow" for Cycling through selection

Could you create another new issue?

then shift + right for adding selection.

Does it mean adding a shift + right option to "Select a suggestion key" ?

@tadashi-aikawa
Copy link
Owner Author

@aubreyz
Added in v7.0.0-beta8 🚀

@aubreyz
Copy link

aubreyz commented Jun 4, 2022

I haven't tested every one, but the shift-space works great and is nearly seamless.

I am not sure what happens though if I select an item lower down on the list via the keyboard - it might be intuitive if I pressed down down and then shift-space (or whichever one was selected), or in that context a simple enter might be good as well because if someone is navigating in the suggestion list it is obvious they want to make a choice so enter would be fine here.

@tadashi-aikawa
Copy link
Owner Author

Thank you for your confirming :)

it might be intuitive if I pressed down down and then shift-space (or whichever one was selected), or in that context a simple enter might be good as well because if someone is navigating in the suggestion list it is obvious they want to make a choice so enter would be fine here.

I see. I agree with the opinion, but it seems a bit complicated. 🤔

@tadashi-aikawa
Copy link
Owner Author

Released in v7.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants