FR: Make suggestions confirmable only after pressing the key to make a selection.

[L7Cy]

I use the Enter key to confirm suggestions, but I often accidentally confirm a suggestion when I want to enter a new line at the end of a line. For example, if I type the word "常温" and then type a new line at the end of the line, I accidentally confirm the suggestion "常温常圧超伝導".

2023-08-19.11.30.35.mov

In the video, I'm using Google Japanese Input, but with Google Japanese Input, the suggestion cannot be confirmed until a selection key (such as Tab or Space) is pressed. Is there a way in this plugin to make suggestions confirmable only when a selection key is pressed? If not, I would be grateful if you could add this feature. 🙇‍♂️

[tadashi-aikawa]

Hi, @L7Cy :)

I think you could turn off the Complement automatically option and use the Show suggestions command.

[L7Cy]

It is true that the problem can be solved in that way, but since it is convenient to have suggestions appear automatically, I don't want to disable the "Complement automatically" option.

[tadashi-aikawa]

@L7Cy
How about Select a suggestion key ? You could use many keys instead of "Enter".

[L7Cy]

Of course I know I can select other keys, and I've set and used Cmd+Enter before, but the suggestion feature provided by Obsidian requires the use of the Enter key, which is confusing to me.😵

[tadashi-aikawa]

@L7Cy
Got it.

After all, Obsidian and Various Complements cannot determine whether the user wants a line break or not. I think triggering a single key before displaying a suggestion would not fundamentally solve the problem, as it would only make it more cumbersome to do so each time.

[L7Cy]

There's no need to determine whether the user wants a line break or not. The problem is that the top item is already selected when the suggestion is displayed. I just want to select the "do not select" from the suggestions. With Google Japanese Input, I can choose whether or not to select from the suggestions by pressing or not pressing the key to select. I have never found this to be cumbersome.

[tadashi-aikawa]

@L7Cy
OK. I got it that your FR is "Don't focus the first suggestion until pushing 'cycle throw suggestions keys'".

I’m unsure if it’s possible, but I’ll survey and consider it👍

[tadashi-aikawa]

@L7Cy
I have surveyed it. Unfortunately, It is not easy for the current version of Obsidian. Let me add the long-term label to this issue.

[tadashi-aikawa]

@L7Cy
I came up with a tricky idea that might enable the implementation of this feature🛀

I'll try it tomorrow.

[tadashi-aikawa]

LGTM on my settings 👀

[tadashi-aikawa]

@L7Cy
Released in v8.4.0 🚀

Please let me know if you have any concerns or issues.

[L7Cy]

Amazing!! Thank you!🙏
However, I have one small concern. When typing a word that starts with Hiragana, such as "こうもり問題", I think there are times when you might confirm it as it is without selecting in IME, but at the same time as confirming, the suggestions will no longer be displayed.

2023-08-20.16.56.05.mov

[tadashi-aikawa]

@L7Cy
Not reproduce it on Microsoft IME. I'll download Google日本語入力 and survey it.

[tadashi-aikawa]

@L7Cy
Unfortunately, I couldn't reproduce it even I used Google日本語入力. Could you tell me the reproduction steps in the sandbox vault?

2023-08-20_17h38_00.mp4

[L7Cy]

I was able to reproduce this by enabling "No auto-focus until the cycle", creating a wikilink to the "こうもり問題" in any note, and confirming after typing "こうもり". My environment is MacOS, so this may be a MacOS-specific problem.

2023-08-20.17.54.22.mov

[tadashi-aikawa]

@L7Cy
Thanks :)

My environment is MacOS, so this may be a MacOS-specific problem.

I think so, too. Did you press the Enter key before confirming "こうもり" ?

[L7Cy]

The Enter key is only pressed to confirm.

2023-08-20.18.26.03.mov

[tadashi-aikawa]

@L7Cy
Thank you for your quick response!

Probably, I could fix the issue, so I will release it as v8.4.1 soon 👍

( But I have no macOS environment.. so it would be great if you confirm it after the next release🙏 )

[tadashi-aikawa]

@L7Cy
Released in v8.4.1 🙏🙏

[L7Cy]

It seems to be working fine! Thanks!!🙏

[tadashi-aikawa]

I’m glad to hear that! Thanks!