Allow android Q to use wifi api for now #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcf
approved these changes
Jun 10, 2019
|
@tadasr I found a couple of bugs which are addressed in this PR. |
edpaget
approved these changes
Jun 19, 2019
|
@tadasr any chance you had a look at this? |
ZachJMoore
added a commit
to ZachJMoore/react-native-iot-wifi
that referenced
this pull request
Oct 18, 2019
TCIL-CWT-3141: Support library auto linking in React Native >= 0.60
TCIL-CWT-3142: update compileSdkVersion for Android
SaveConfiguration API is deprecated on API 26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bit more testing turns out Android Q is still supporting the old API and rejecting the wifi connect calls for it makes less sense.
This PR will
< Oreoillegal violationcrash related to callback being invoked more than once when attempting to force bind to a wifi network