Support React v17 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v17, the synthetic event object structure is changed. As you can see below link, the Interface of specific event is not referenced by constructor in the event's proto (Object.getPrototypeOf return value). See: https://github.com/facebook/react/blob/v17.0.0/packages/react-dom/src/events/SyntheticEvent.js#L28 But when I look at BaseSyntheticEvent in ReactSyntheticEventType, some properties are still being used. The internal implementation was modified in consideration of backward compatibility. See: https://github.com/facebook/react/blob/v17.0.0/packages/react-dom/src/events/ReactSyntheticEventType.js#L25-L36
taehwanno
force-pushed
the
update/react-v17
branch
from
0020758
to
9011f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React v17, the synthetic event object structure is changed. As you can see below link, the Interface of specific event is not referenced by constructor in the event's proto (
Object.getPrototypeOfreturn value).See: https://github.com/facebook/react/blob/v17.0.0/packages/react-dom/src/events/SyntheticEvent.js#L28
But when I look at
BaseSyntheticEventinReactSyntheticEventType, some properties are still being used. is-react-synthetic-event's internal implementation was modified in consideration of backward compatibility.See: https://github.com/facebook/react/blob/v17.0.0/packages/react-dom/src/events/ReactSyntheticEventType.js#L25-L36
checklist