This repository has been archived by the owner on Jun 3, 2019. It is now read-only.
Enabling snapshot timestamps and other refactors #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ readme improvement + upgraded all dependencies to latest versions - removed unused variables
|
Thank you for your contribution, appreciate the work, but I'm going to favor #7 for now. And uh, we prefer semicolons here :) tho I didn't manage to get eslint/prettier up, this was built under experimental usage. |
|
Feel free to send in another PR for refactoring, I'll gladly accept that. |
|
@alvinthen, before I send another PR, I'd like to ask your opinion about this configuration: // .prettierrc
{
"semi": true,
"singleQuote": true,
"trailingComma": "es5"
}If approved, will submit a PR with semicolons and add Prettier as a dev dependency. |
|
Looks good to me :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions:
Removals:
Feel free to improve my PR, as this is a quick fix on enabling snapshot timestamps. 馃槃