Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_connection_keepalive(TestCurbCurlMulti) skipped with Curl 8+ #447

Open
voxik opened this issue Dec 1, 2023 · 1 comment
Open

test_connection_keepalive(TestCurbCurlMulti) skipped with Curl 8+ #447

voxik opened this issue Dec 1, 2023 · 1 comment

Comments

@voxik
Copy link

voxik commented Dec 1, 2023

I know the Curl 8+ is out of support matrix. Nevertheless, Curl 8.4.0 is the version available in Fedora and everything seems to be fine except that test_connection_keepalive(TestCurbCurlMulti) is skipped. This seems to be due to this condition:

omit("Skip, libcurl too old (< 7.22.0)") if Curl::CURL_VERSION.split('.')[1].to_i <= 22

Which does not account for major version.

@voxik
Copy link
Author

voxik commented Dec 1, 2023

The commit 06e81e6 introducing the condition above remove use Google, while the test case keeps referring to Google:

# additionally, if ss allows this to pass on linux without requesting google i think this is a good trade off... leaving some of the thoughts below

assert (after_open - before_open) < 3, "with max connections set to 1 at this point the connection to google should still be open"
assert (after_open - before_open) > 0, "with max connections set to 1 at this point the connection to google should still be open"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant