Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with ghc-8.2.2 using Nix #415

Merged
merged 3 commits into from Sep 17, 2018
Merged

Build with ghc-8.2.2 using Nix #415

merged 3 commits into from Sep 17, 2018

Conversation

PierreR
Copy link
Contributor

@PierreR PierreR commented Sep 8, 2018

This is not ready to be merged.

I would like to discuss this PR to get feedback and help.

This PR allows me to install Taffybar compiled with ghc-8.2.2. This is necessary because of #358.

You can try it out in nixos (and I guess also with nix and other linux distro) by using this command:

nix-env -i -f https://github.com/pierrer/taffybar/tarball/20584dafc952fbe5ee36136e0492500749ea7faa

It is going to take quite a while because a lot of the dependencies are not in the nixos default binary cache.

One issue remains. It works on the stable nixos channel (18.03) but it won't work so well when I use the unstable channel (18.09). In 18.09 it completes the building process without problem but Taffybar will fail to recompile the user configuration. It complains that it can't find the imported taffybar modules.

As a bonus, I would also like to speed up the build/compilation process (by disabling profiling globally, using `justStaticExecutables´, ...). Any idea or suggestion welcomed.

When I am happy about the workflow I will probably push it to cachix

Thanks for your help and feedback.

@colonelpanic8
Copy link
Member

Thanks for submitting, this should be helpful to a lot of people. I'll try it out on my machine in the near future.

@PierreR
Copy link
Contributor Author

PierreR commented Sep 13, 2018

@IvanMalison I think it is safe to merge this if you believe it can be useful. I have pushed the nar files into cachix: https://taffybar.cachix.org/. If it works as expected there would be no compilation.
If the default ghc is not ghc8.2.2 the dynamic reloading of the configuration (with dyre) might fail. I still have to figure out that part.

You don't need to install cachix to test it but it provides an easy way to add the cache with cachix use taffybar.

@colonelpanic8 colonelpanic8 merged commit 316ff1e into taffybar:master Sep 17, 2018
@colonelpanic8
Copy link
Member

@PierreR I'm confused. Why does this need to exist at all. Seems like we should just use the existing nixpkgs derivations for taffybar.

@PierreR
Copy link
Contributor Author

PierreR commented May 28, 2019

Yep it can be removed now that everything is working correctly in nixpkgs

@PierreR
Copy link
Contributor Author

PierreR commented May 28, 2019

I can do a PR to clean this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants