Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace images #66

Closed
wants to merge 80 commits into from
Closed

Conversation

teleshoes
Copy link
Contributor

  1. Generalizes WSS markup functions to IO actions
  2. add Image widget to Workspace buttons, and include the hbox for more general control
  3. add imageSelector to allow endusers to write their own image selection functions
    taffybar

this is a breaking change and it doesnt provide an elegant ootb solution for images. however, folks who dont want images dont have to do anything, and folks who do can write an imageSelector. if someone feels ambitious, a default imageSelector could be written to give a decent ootb experience.

i dont expect you to merge this, but it would be really great if you did, or impld something like it, not least because i could stop maintaining a fork.

escherdragon and others added 30 commits November 18, 2012 09:21
Conflicts:
	src/System/Information/Battery.hs
	src/System/Taffybar/MPRIS.hs
	src/System/Taffybar/XMonadLog.hs
	taffybar.cabal
The window should intercept the delete event and hide itself,
otherwise it's gone forever.
updates the barColor and barBackgroundColor in the BarConfig of a VeticalBar.
repaints the bar if it its bootstrapped, or just update cfg for next time
Conflicts:
	src/System/Taffybar/SimpleClock.hs
added imageSelector to PagerConfig
added image widgets and a frame to workspace switcher
{still need to plug in title/class and call markImg}
e.g.:
activeWorkspace = colorize "white" "black"
=>
activeWorkspace = markWs $ colorize "white" "black"
…nally crash

it was happening outside of gtk main thread, and prone to race conditions
Conflicts:
	src/System/Information/EWMHDesktopInfo.hs
	src/System/Information/X11DesktopInfo.hs
	src/System/Taffybar/Hooks/PagerHints.hs
	src/System/Taffybar/LayoutSwitcher.hs
	src/System/Taffybar/Pager.hs
	src/System/Taffybar/SimpleClock.hs
	src/System/Taffybar/Widgets/Util.hs
	src/System/Taffybar/WindowSwitcher.hs
	src/System/Taffybar/WorkspaceSwitcher.hs
@travitch
Copy link
Member

I do like the idea. Thanks for the screenshot.

If I recall, my main concern were the IO types introduced in your workspace drawing code. I'm going to try to think of a way to include both so that simpler configurations can completely ignore it.

@ivanbalashov239
Copy link

@travitch will you merge it? Or make the alternative?
@teleshoes are you still using your fork?

@teleshoes
Copy link
Contributor Author

yep, i use it every day, and i would SO DEARLY LOVE not to have to keep managing these awful merge conflicts every few months. naturally, they get worse each time.

personally, i agree that the feature is not polished enough for wide use, but i DO think that my code could form the foundation of a full-fledged impl of this feature, and its not like it hurts things. (afaik, only a handful of humans on the face of the earth use my fork)

@teleshoes
Copy link
Contributor Author

see #167

@teleshoes
Copy link
Contributor Author

#167 was merged!

@teleshoes teleshoes closed this Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants