Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of control characters #368

Open
dralley opened this issue Mar 11, 2022 · 0 comments
Open

Handling of control characters #368

dralley opened this issue Mar 11, 2022 · 0 comments
Labels
enhancement help wanted

Comments

@dralley
Copy link
Collaborator

dralley commented Mar 11, 2022

XML 1.0 disallows most kinds of control characters. XML 1.1 allows some control characters, but only when they've been encoded as numeric character references.

There should probably be some way to encode these provided at minimum, or maybe prevent the writer from writing them. I haven't gotten around to checking whether the reader checks for this yet, but libxml2 seems to throw a warning / error when it encounters raw illegal control characters.

https://en.wikipedia.org/wiki/Valid_characters_in_XML
Mingun added a commit to Mingun/quick-xml that referenced this issue Oct 1, 2022
@Mingun
Switch to new serializer
fe5ed28 
Fixes tafia#252 - ok
Fixes tafia#280 - ok
Fixes tafia#287 - ok
Fixes tafia#343 - ok
Fixes tafia#346 - not ok
Fixes tafia#361 - ok
Partially addresses tafia#368
Fixes tafia#429 - ok
Fixes tafia#430 - ok
Mingun added a commit to Mingun/quick-xml that referenced this issue Oct 1, 2022
@Mingun
Switch to new serializer
aea814a 
Fixes tafia#252
Fixes tafia#280
Fixes tafia#287
Fixes tafia#343
Fixes tafia#346
Fixes tafia#361
Partially addresses tafia#368
Fixes tafia#429
Fixes tafia#430
@Mingun Mingun mentioned this issue Oct 1, 2022
Merged
Mingun added a commit to Mingun/quick-xml that referenced this issue Oct 24, 2022
@Mingun
Switch to new serializer
d9410c1 
Fixes tafia#252
Fixes tafia#280
Fixes tafia#287
Fixes tafia#343
Fixes tafia#346
Fixes tafia#361
Partially addresses tafia#368
Fixes tafia#429
Fixes tafia#430

Fixes all tests
Mingun added a commit to Mingun/quick-xml that referenced this issue Oct 25, 2022
@Mingun
Switch to new serializer
5019e26 
Fixes tafia#252
Fixes tafia#280
Fixes tafia#287
Fixes tafia#343
Fixes tafia#346
Fixes tafia#361
Partially addresses tafia#368
Fixes tafia#429
Fixes tafia#430

Fixes all tests
Mingun added a commit to Mingun/quick-xml that referenced this issue Oct 26, 2022
@Mingun @dralley
Switch to new serializer
4f376b1 
Fixes tafia#252
Fixes tafia#280
Fixes tafia#287
Fixes tafia#343
Fixes tafia#346
Fixes tafia#361
Partially addresses tafia#368
Fixes tafia#429
Fixes tafia#430

Fixes all tests

Co-authored-by: Daniel Alley <dalley@redhat.com>
@Mingun Mingun mentioned this issue Oct 27, 2022
Draft
JOSEPHGILBY pushed a commit to JOSEPHGILBY/quick-xml that referenced this issue Nov 5, 2022
@Mingun @dralley
Switch to new serializer
fce286e 
Fixes tafia#252
Fixes tafia#280
Fixes tafia#287
Fixes tafia#343
Fixes tafia#346
Fixes tafia#361
Partially addresses tafia#368
Fixes tafia#429
Fixes tafia#430

Fixes all tests

Co-authored-by: Daniel Alley <dalley@redhat.com>
JOSEPHGILBY pushed a commit to JOSEPHGILBY/quick-xml that referenced this issue Nov 5, 2022
@Mingun @dralley
Switch to new serializer
71fc17d 
Fixes tafia#252
Fixes tafia#280
Fixes tafia#287
Fixes tafia#343
Fixes tafia#346
Fixes tafia#361
Partially addresses tafia#368
Fixes tafia#429
Fixes tafia#430

Fixes all tests

Co-authored-by: Daniel Alley <dalley@redhat.com>
@dralley dralley mentioned this issue Jun 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mingun @dralley