Add set_name and clear_attributes functions to BytesStart

[meven]

Fixes #148

[jonhoo]

Those fns should be pub fn, that's why you're getting the warnings :)

[meven]

Those fns should be pub fn, that's why you're getting the warnings :)

Thanks ;) that's been taking care of.

[jonhoo]

@tafia looks like the Travis failure is just rustfmt-preview being unavailable for nightly (the component is now just called rustfmt).

[tafia]

Looks great.
Could you just amend the comment to avoid confusion?

[tafia]

Thanks for the PR and sorry for the late response.
Can you please just modify the comment on set_name?
I'll push changes to travis in the meantime.

[meven]

Last change made me think that perhaps set_names should not edit the attributes and keep them.
It would end up as :

    /// Edit the name of the BytesStart in-place
    pub fn set_name(&mut self, name: &[u8]) -> &mut BytesStart<'a> {
        {
            let bytes = self.buf.to_mut();
            bytes.splice(..self.name_len, name.to_vec());
        }
        self.name_len = name.len();
        self
    }

[tafia]

Sounds better indeed!

[meven]

Sounds better indeed!

Done, I feel like this can be merged

[tafia]

Thanks!

[jonhoo]

@meven I don't think the to_vec call here is needed. It'd be good to avoid the extra allocation!

[meven]

I did not find a better way I would expect the same but I ran into

error[E0271]: type mismatch resolving `<&[u8] as std::iter::IntoIterator>::Item == u8`
   --> src/events/mod.rs:178:19
    |
178 |             bytes.splice(..self.name_len, name);
    |                   ^^^^^^ expected reference, found u8
    |
    = note: expected type `&u8`
               found type `u8`

It seems I still need some conversion, name &[u8] implements IntoIterator<u8> but I need an IntoIterator<&u8>. Maybe There is some simple trick I am missing.

[jonhoo]

Ah, I've run into this in the past. It's a little silly. Basically what you want is name.iter().cloned() or name.iter().map(|&b| b) to tell the compiler that you want to utilize the fact that u8 is Copy.

[meven]

Thanks, will make another PR