Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From<QName> for BytesStart and BytesEnd #758

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Jun 16, 2024

Found a small gap in our API

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.80%. Comparing base (7558577) to head (3afbbaa).
Report is 1 commits behind head on master.

Files Patch % Lines
src/events/mod.rs 50.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   61.81%   61.80%   -0.01%     
==========================================
  Files          41       41              
  Lines       16798    16805       +7     
==========================================
+ Hits        10384    10387       +3     
- Misses       6414     6418       +4     
Flag Coverage Δ
unittests 61.80% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dralley dralley merged commit d66df32 into tafia:master Jun 16, 2024
6 checks passed
@Mingun Mingun deleted the from-qname branch June 16, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants