Rework handling general entity references (&entity;)
#766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dEntity` and tweak error message
…onstruction in a text
failures (18):
serde-de (9):
borrow::escaped::element
borrow::escaped::top_level
resolve::resolve_custom_entity
trivial::text::byte_buf
trivial::text::bytes
trivial::text::string::field
trivial::text::string::naked
trivial::text::string::text
xml_schema_lists::element::text::string
serde-migrated (1):
test_parse_string
serde-se (5):
with_root::char_amp
with_root::char_gt
with_root::char_lt
with_root::str_escaped
with_root::tuple
--doc (3):
src\de\resolver.rs - de::resolver::EntityResolver (line 13)
src\reader\ns_reader.rs - reader::ns_reader::NsReader<&'i[u8]>::read_text (line 870)
src\reader\slice_reader.rs - reader::slice_reader::Reader<&'a[u8]>::read_text (line 186)
…xpanded entities
Text events produces by the Reader can not contain escaped data anymore, all such data is represented by the Event::GeneralRef
failures:
src\reader\ns_reader.rs - reader::ns_reader::NsReader<&'i[u8]>::read_text (line 870)
src\reader\slice_reader.rs - reader::slice_reader::Reader<&'a[u8]>::read_text (line 185)
This was referenced Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big change in handling general entity references and character references. Open PR early to get feedback.
With this changes we can correctly parse document
as equivalent normalized document
<root/>The updated
custom_entitiesexample shows how it would be possible to implement requirement from the specification about parsed general entities. Serde deserializer did not updated yet, because this is not trivial part and probably that will be done in another PR.Of course, such change probably makes the performance worse, I didn't measure impact yet.