Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize fast path with Duration-based wait time #368

Merged
merged 10 commits into from Oct 13, 2021

Conversation

jeremyandrews
Copy link
Member

@jeremyandrews jeremyandrews commented Oct 10, 2021

0.13.3

  • 9,668
  • 10,385
  • 10,031

0.14.1-dev (before this PR)

  • 7,526
  • 7,739
  • 7,669

0.14.1-dev (after this PR)

  • 9,919
  • 10,206
  • 10,082

@jeremyandrews jeremyandrews changed the title minimize changes when adding support for Duration-based wait time optimize fast path with Duration-based wait time Oct 12, 2021
@jeremyandrews
Copy link
Member Author

I've run a comparison of 0.13.3, 0.14.1-dev without this PR, and 0.14.1-dev with this PR, confirming that this seems to fix the reported performance regression:
https://docs.google.com/spreadsheets/d/1E7LwL_kJmRgRJ_BVW3QPTIoe7hqmODGhOpiGWjppuNY/edit#gid=0

@zezic
Copy link

zezic commented Oct 12, 2021

I can confirm that this PR fixes the #367.

Copy link
Collaborator

@LionsAd LionsAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTBM - with two nits / questions

@jeremyandrews jeremyandrews merged commit 3db41cf into tag1consulting:main Oct 13, 2021
@jeremyandrews jeremyandrews deleted the revert-test branch October 13, 2021 09:23
@jeremyandrews jeremyandrews mentioned this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throughput performance drop
3 participants