Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad allocation on mp3 file load #697

Closed
razzeee opened this issue Dec 7, 2015 · 4 comments · Fixed by #698
Closed

Bad allocation on mp3 file load #697

razzeee opened this issue Dec 7, 2015 · 4 comments · Fixed by #698
Labels

Comments

@razzeee
Copy link

razzeee commented Dec 7, 2015

We bumped Kodi to taglib 1.10 and it seems, like we found a regression.

When we try to access this file: http://saraev.ca/01%20-%20Eternity.mp3
via

file = mpegFile = new MPEG::File(stream, ID3v2::FrameFactory::instance());

it fails with a bad allocation
If you need any more info, please let me know.

image

@TsudaKageyu
Copy link
Contributor

Hi @razzeee, I have located the cause of this issue.
I will create a pull request soon, and describe the cause there.
Thanks!

@razzeee
Copy link
Author

razzeee commented Dec 8, 2015

Do you guys do hotfix releases for such things or should we just patch our version of 1.10 when this hits master?

@silverhammermba
Copy link

Ah, you beat me! I found the same crash on Linux. Downgrading taglib to 1.9.1 got Kodi working agian.

@razzeee
Copy link
Author

razzeee commented Dec 15, 2015

So will there be a hotfix or should be cherry pick the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants