Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] avoid freezes reading incomplete mp3 files #842

Open
shaforostoff opened this issue Nov 9, 2017 · 3 comments · May be fixed by #857
Open

[patch] avoid freezes reading incomplete mp3 files #842

shaforostoff opened this issue Nov 9, 2017 · 3 comments · May be fixed by #857

Comments

@shaforostoff
Copy link
Contributor

avoid being stuck in previousFrameOffset() called from lastFrameOffset() when position >= length()

https://pastebin.com/xjc4PK5N

@shaforostoff shaforostoff linked a pull request Mar 2, 2018 that will close this issue
@scotchi
Copy link
Member

scotchi commented Sep 10, 2019

Could you send an example file that's triggering this issue? (to wheeler@kde.org)

@shaforostoff
Copy link
Contributor Author

sorry, but i don't see any sense sending you problematic files. I have already sent you an aac file as part of another issue, but none of my submitted patches fixing rare corner cases are being accepted, with answers like, to quote, "Unless it's something very common, my impulse is not to work around this sort of brokenness."

@scotchi
Copy link
Member

scotchi commented Sep 10, 2019

You're right that TagLib in general is intentionally rather strict with parsing files. If there are broken files that aren't created by major applications (like, say, iTunes) we tend to not include code to work around them, and usually just ignore the rest of the metadata. But it sounded like on this issue that it might lead to a hang in the application, which is a somewhat different case (and one that we definitely would want to work around).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants