Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagLib 64bit Narrowing Conversions #928

Closed
XiNiHa opened this issue Sep 26, 2019 · 4 comments
Closed

TagLib 64bit Narrowing Conversions #928

XiNiHa opened this issue Sep 26, 2019 · 4 comments

Comments

@XiNiHa
Copy link

XiNiHa commented Sep 26, 2019

I am currently getting a large amount of unsafe type conversion(narrowing) warnings when I compile TagLib in MSVS 2017 Win64. While I don't think it would be a real problem, is it going to be fixed in the next release?
@XiNiHa XiNiHa changed the title TagLib 64bit support in Windows TagLib 64bit Narrowing Conversions Sep 26, 2019
@scotchi
Copy link
Member

scotchi commented Sep 26, 2019

Unless a patch is submitted, probably not. (I personally do very little development on Windows, and the folks who have typically maintained the Windows side of things are no longer active.)

@timnbraun
Copy link

Here's a patch that fixes this for the msys toolchain on Windows 11

0001-Add-_WIN64-support-in-refcounter-class.patch.txt

@neheb
Copy link
Contributor

neheb commented Aug 17, 2023

refcounter is gone

@sbooth
Copy link
Contributor

sbooth commented Aug 18, 2023

This patch is no longer required.

@sbooth sbooth closed this as completed Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sbooth @scotchi @neheb @XiNiHa @timnbraun