Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP4 - setAlbum/Artist/Genre/Comment() accepts empty string to remove tag #930

Closed
wants to merge 1 commit into from
Closed

MP4 - setAlbum/Artist/Genre/Comment() accepts empty string to remove tag #930

wants to merge 1 commit into from

Conversation

whatdoineed2do
Copy link
Contributor

Closes #929

As per documentation/functionality across other tpyes (mp3/flac/...); m4a do not honour removing tags when input param is String() or String::null

setAlbum/Artist/Genre/Comment() accepts empty string to remove the ta…
18276c5 
…g as per

documentation/functionality across other tpyes (mp3/flac/...); m4a do not honour
@whatdoineed2do whatdoineed2do changed the title setAlbum/Artist/Genre/Comment() accepts empty string to remove tag MP4 - setAlbum/Artist/Genre/Comment() accepts empty string to remove tag Oct 5, 2019
@ufleisch
Copy link
Contributor

Thanks for the PR, is now fixed using #984.

@ufleisch ufleisch closed this Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M4a - setXXX() does not remove tag when param is String()
2 participants
@whatdoineed2do @ufleisch