Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction texts for enemies #76

Merged
merged 12 commits into from
Oct 31, 2017
Merged

Introduction texts for enemies #76

merged 12 commits into from
Oct 31, 2017

Conversation

AlissaWe
Copy link
Contributor

Implements introduction texts for enemies.
Includes a standard intro and specific intros for some of the enemies.

@tagniam
Copy link
Owner

tagniam commented Oct 31, 2017

LGTM. However, for the GetIntro implementations, you should just return the string constant instead of having to allocate the IntroText variable everytime

@AlissaWe
Copy link
Contributor Author

You mean like this?

@tagniam tagniam merged commit 3c92ed5 into tagniam:master Oct 31, 2017
@tagniam
Copy link
Owner

tagniam commented Oct 31, 2017

Yep. Thanks for implementing a cool feature! I especially like the squid intro.

@tagniam tagniam mentioned this pull request Oct 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlissaWe @tagniam