Fix cancelling queries #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
force-pushed
the
fix-cancel-queries
branch
from
5050681
to
e842a89
Compare
MasterOdin
force-pushed
the
fix-cancel-queries
branch
from
e842a89
to
874e67f
Compare
|
LGTMj. Thank you! |
|
@tagomoris, I ran into this issue recently. It doesn't look like this fix has been released to NPM yet. May a new version be published to NPM sometime soon? |
|
I've published v1.1.0 with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes a bug introduced in #74, where the logic was changed such that anything except a 200 response was considered an error. However, when cancelling a query, a 204 is returned, and that would cause the callback passed to
.killto have an error object, though the query itself was still properly cancelled. I've included tests for the two paths wherein a user may have a query be cancelled.I was not able to reproduce the error reported in #75, and the tests use relatively latest versions of presto/trino, so I"m not sure why they were seeing a 404 error.
This also fixes a bug where if you did not pass a callback to
killmethod, then would hit an undefined error, but only if an error was returned from the request. If no error was returned, then things would work fine. Now, if no callback is provided, then the error (or not) is silently swallowed, otherwise passed back to the user.