Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing falsey bug for when settings.orderby == false #1120

Merged
merged 3 commits into from May 11, 2020

Conversation

jonathan-shahen
Copy link
Contributor

@jonathan-shahen jonathan-shahen commented May 8, 2020

This pull request solves the issues: #1115, #1119, and #1118

The problem was when settings.orderby == false, it would cause the old inline if statement to become false and thus set the orderby value to the default true.

Link to description of the falsey issue (https://stackoverflow.com/questions/3390396/how-to-check-for-undefined-in-javascript).

The other commit adds the suggested fixes to the README.

@uggrock
Copy link
Member

uggrock commented May 10, 2020

Thanks for the fix and the pull request. In order to accept it, we need that you agree first to our Contributor License Agreement available here: https://www.tagspaces.org/contribute/

Copy link
Member

@uggrock uggrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

README.md Show resolved Hide resolved
@jonathan-shahen
Copy link
Contributor Author

I am willing to sign the Contributor License Agreement, and provide my name, email, and github id; but I am not comfortable providing my mailing address, country, and phone number.

How can we proceed?

@uggrock
Copy link
Member

uggrock commented May 11, 2020

Please download, print and fill our this PDF, with the information you are comfortable with.
https://www.tagspaces.org/content/tagspaces-cla-v1.pdf
Then scan it and send it to me at contact at tagspaces dot org .

@uggrock uggrock merged commit c679cc9 into tagspaces:develop May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants