Fixing falsey bug for when settings.orderby == false #1120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves the issues: #1115, #1119, and #1118
The problem was when
settings.orderby == false
, it would cause the old inline if statement to becomefalse
and thus set theorderby
value to the defaulttrue
.Link to description of the falsey issue (https://stackoverflow.com/questions/3390396/how-to-check-for-undefined-in-javascript).
The other commit adds the suggested fixes to the README.