Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Feat/test multi arch #106

Merged
merged 1 commit into from Jun 7, 2017
Merged

Feat/test multi arch #106

merged 1 commit into from Jun 7, 2017

Conversation

Pierozi
Copy link
Contributor

@Pierozi Pierozi commented May 24, 2017

Following PR #97 of @mathroc

The Dockerfile has been fixed in order to run with success all the suite test.
Makefile was also created to make it easier to run testing with different tools like cross with architecture emulation in QEMU inside docker.

@coveralls
Copy link

coveralls commented May 24, 2017 •
edited

Coverage Status

Coverage remained the same at 93.502% when pulling 3a83bac on Pierozi:feat/test-multi-arch into e7aa963 on tagua-vm:master.

@Hywan
Copy link
Member

Hywan commented May 29, 2017

Why adding cross right?

@Hywan Hywan self-assigned this May 29, 2017
@Hywan Hywan added this to the 0.2.0 milestone May 29, 2017
@Pierozi
Copy link
Contributor Author

Pierozi commented May 29, 2017

Cross is only in Makefile target, your not force to install it, but if you do not want theses script in the Project I understand, in this case maybe cloud just specify in Documentation / Readme under Dev Tools section.

Cross was pretty easy for build and test multi environment quickly.
Makefile was only a lazy way to remember the command to launch.

@Hywan
Copy link
Member

Hywan commented May 30, 2017

This PR introduces 2 things: Docker stuff, and a Makefile. As far as I understand, they are not relateed. Please, choose one :-).

@Pierozi
Dockerfile : Run test into container
7dae9ae 
Test multi arch : Run test with cross tool

remove makefile

Dockerfile:  two composes services cli and autorun test
@Pierozi
Copy link
Contributor Author

Pierozi commented Jun 3, 2017

My bad, Makefile removed :)

  • docker-compose up test
    Will auto build and execute test inside a container based on Dockerfile
  • docker-compose up -d cli
    Will run container and keep it alive to be able to use interactive mode

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.433% when pulling 7dae9ae on Pierozi:feat/test-multi-arch into 7b21875 on tagua-vm:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 3, 2017 •
edited

Coverage Status

Coverage remained the same at 93.433% when pulling 7dae9ae on Pierozi:feat/test-multi-arch into 7b21875 on tagua-vm:master.

@Hywan
Copy link
Member

Hywan commented Jun 6, 2017

Sorry to insist, but:

docker-compose up -d cli

What's the goal of this for this project?

@Pierozi
Copy link
Contributor Author

Pierozi commented Jun 6, 2017

as said

Will run container and keep it alive to be able to use interactive mode

Useful for debug mode when you want execute interactive command.

@Hywan
Copy link
Member

Hywan commented Jun 6, 2017

What interactive command do we have on this project :-/? Again, I am not convinced at all by the needs of Docker for this library :-(.

@Pierozi
Copy link
Contributor Author

Pierozi commented Jun 6, 2017

In this case, drop it! :)
I'm aware a Docker is trivial for Tagua, the developer already have rust installed (obviously)
It's just a virtual chroot to run test on proper versions and have a clean slate each time it's running.

@Hywan Hywan merged commit 4e2f1c9 into tagua-vm:master Jun 7, 2017
@Hywan Hywan removed the in progress label Jun 7, 2017
@Hywan
Copy link
Member

Hywan commented Jun 7, 2017

@Pierozi Can you update the README.md please :-)?

@mathroc mathroc mentioned this pull request Jun 7, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hywan Hywan Hywan approved these changes

Assignees

@Hywan Hywan

Labels
component-build enhancement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pierozi @coveralls @Hywan