Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

AST: Use SmallVec for Name #109

Merged
merged 4 commits into from Jun 7, 2017
Merged

AST: Use SmallVec for Name #109

merged 4 commits into from Jun 7, 2017

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Jun 2, 2017

The Name enum uses small vectors instead of vectors to represent part of the names (if Qualified, RelativeQualified, and FullyQualified). Small vectors are located on the stack if the number of items is lower than $N$, after that they are located on the heap.

The number $N = 5$ is strictly arbitrary so far.

The most important commit is 0535529.

Hywan added 2 commits June 2, 2017 16:25
The `Name` enum uses small vectors instead of vectors to represent part
of the names (if `Qualified`, `RelativeQualified`, and
`FullyQualified`). Small vectors are located on the stack if the number
of items is lower than $N$, after that they are located on the heap.

The number $N = 5$ is strictly arbitrary so far.
@Hywan Hywan added this to the 0.2.0 milestone Jun 2, 2017
@Hywan Hywan self-assigned this Jun 2, 2017
@Hywan Hywan requested a review from jubianchi June 2, 2017 14:33
@Hywan Hywan changed the title AST: Use SmallVec for Name [WIP] AST: Use SmallVec for Name Jun 2, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.433% when pulling 36c5b21 on Hywan:smallvec into 7b21875 on tagua-vm:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.433% when pulling 36c5b21 on Hywan:smallvec into 7b21875 on tagua-vm:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.433% when pulling 36c5b21 on Hywan:smallvec into 7b21875 on tagua-vm:master.

@coveralls
Copy link

coveralls commented Jun 2, 2017

Coverage Status

Coverage remained the same at 93.433% when pulling 36c5b21 on Hywan:smallvec into 7b21875 on tagua-vm:master.

@Hywan Hywan changed the title [WIP] AST: Use SmallVec for Name AST: Use SmallVec for Name Jun 6, 2017
@coveralls
Copy link

coveralls commented Jun 6, 2017

Coverage Status

Coverage increased (+0.04%) to 93.471% when pulling 9909e84 on Hywan:smallvec into 7b21875 on tagua-vm:master.

@coveralls
Copy link

coveralls commented Jun 6, 2017

Coverage Status

Coverage increased (+0.04%) to 93.471% when pulling 9909e84 on Hywan:smallvec into 7b21875 on tagua-vm:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.471% when pulling 9909e84 on Hywan:smallvec into 7b21875 on tagua-vm:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.471% when pulling 9909e84 on Hywan:smallvec into 7b21875 on tagua-vm:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.471% when pulling 9909e84 on Hywan:smallvec into 7b21875 on tagua-vm:master.

@Hywan Hywan merged commit 9909e84 into tagua-vm:master Jun 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants