New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail integration tests if we receive extraneous output on FD 3. #510

Open

tomprince opened this issue Jul 26, 2021 · 0 comments

Contributor

tomprince commented Jul 26, 2021 •

edited

Loading

Originally posted by @exarkun in #498 (comment)

Can we also make this into a test-failing event so that if/when such things arise in the future we can catch them quickly? Or is there so much garbage on FD 3 that it's not even worth trying to make it clean?

It is not straight-forward to do this for a couple of reasons:

the service is not scoped to a single test
I don't think raising an exception here would cause the test to fail, as it will be swallowed by the reactor.

tomprince mentioned this issue

Fix windows integration tests. #498

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment