Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid manager proposal, updated to latest code and Python 3 #1206

Merged
merged 291 commits into from Feb 28, 2023
Merged

Grid manager proposal, updated to latest code and Python 3 #1206

merged 291 commits into from Feb 28, 2023

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst commented Jul 25, 2022 •
edited

Remaining steps:

meejah added 30 commits May 30, 2019 16:01
@meejah
fix storage-client
d0791eb
@meejah
Made A Decision, and start of 'admin add-grid-manager-cert' command
633f36a
@meejah
whitespace
08937c6
@meejah
'tahoe admin add-grid-manager-cert' command
d302a98
@meejah
add a note
c88409a
@meejah
newsfragment
4665617
@meejah
flake8
2cf36cf
@meejah
space-separated paths is a bad idea
cfda360
@meejah
pytest API
16e7bc5
@meejah
get rid of debug
9220dd1
@meejah
make and use set_config instead of internals
3d70557
@meejah
switch around how we do config (avoid space-separated filenames)
f0e3b69
@meejah
cleanup
f0a9240
@meejah
item -> value
11993a2
@meejah
can't re-write a static string
8e363ca
@meejah
grid-manager client config is different
1b3bfd5
@meejah
no mutable defaults
883a3ba
@meejah
clarify further
3af6d74
@meejah
introducer-less -> introducerless
8e8b2f4
@meejah
added example and more explanation for 'add'
235d5de
@meejah
consistently use 'nickname'
18fead0
@meejah
decision made
4340cfa
@meejah
clarify
a98eae3
@meejah
more words about 'daemonize'
fb3f0b7
@meejah
redundant webport
7feed41
@meejah
'tahoe put' not 'tahoe mkdir'
6c15d67
@meejah
spelling
f1ae20a
@meejah
alice -> zara, bob -> yakov and docstrings
65403eb
@meejah
.has_key -> 'in'
97a7672
@meejah
remove early return
5071da2
meejah and others added 18 commits February 20, 2023 22:57
@meejah meejah requested a review from exarkun February 22, 2023 21:14
exarkun
exarkun approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Some comments inline. A few are about coverage but after making them I lost all confidence in all of the coverage tools so it's possibly they're just wrong.

Address comments to your satisfaction and then I'd be happy to see this merged.

src/allmydata/util/jsonbytes.py Outdated Show resolved Hide resolved
src/allmydata/util/configutil.py
try:
tahoe_cfg.remove()
except OSError:
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems worth doing something. I suppose the moveTo below will probably fail if anything goes wrong with this remove? But it might fail with less information or misleading information. A log message here would at least leave a clue about how we got to whatever state moveTo was acting on.

src/allmydata/util/configutil.py Outdated Show resolved Hide resolved
src/allmydata/util/configutil.py Outdated Show resolved Hide resolved
src/allmydata/scripts/admin.py Outdated Show resolved Hide resolved
src/allmydata/scripts/admin.py Show resolved Hide resolved
src/allmydata/scripts/admin.py Show resolved Hide resolved
src/allmydata/scripts/admin.py Show resolved Hide resolved
docs/managed-grid.rst Outdated Show resolved Hide resolved
src/allmydata/test/test_grid_manager.py Show resolved Hide resolved
meejah and others added 8 commits February 23, 2023 15:37
@meejah @exarkun
export it too
a6a2eb1 
Co-authored-by: Jean-Paul Calderone <exarkun@twistedmatrix.com>
@meejah @exarkun
spelling
1587a71 
Co-authored-by: Jean-Paul Calderone <exarkun@twistedmatrix.com>
@meejah @exarkun
types
9f63441 
Co-authored-by: Jean-Paul Calderone <exarkun@twistedmatrix.com>
@meejah @exarkun
whitespace
d55a4a1 
Co-authored-by: Jean-Paul Calderone <exarkun@twistedmatrix.com>
@meejah @exarkun
wording
aed5061 
Co-authored-by: Jean-Paul Calderone <exarkun@twistedmatrix.com>
@meejah
different way to say 'all items okay'
b28ac61
@meejah
more-specific error
5672a28
@meejah
unused
8e7f2cd
@meejah meejah merged commit 6c0c947 into master Feb 28, 2023
@meejah meejah deleted the 2916.grid-manager-proposal.6 branch February 28, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meejah meejah meejah approved these changes

@exarkun exarkun exarkun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@itamarst @coveralls @exarkun @meejah @pythonspeed