Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pyutil dependency #18

Merged
merged 3 commits into from Aug 11, 2020
Merged

remove pyutil dependency #18

merged 3 commits into from Aug 11, 2020

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Jan 17, 2020

Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me (ran tests locally, eye-balled substituted code in pyutils). I just have this nitpick/question about this line in tox.ini:

deps = .[test]

I was unable to find anything in Tox documentation about how expansion of .[test] works. I could sort of infer that it has something to do with the test dependencies from setup.py. Perhaps a note would help?

@sajith
Copy link
Member

sajith commented Aug 11, 2020

I was unable to find anything in Tox documentation about how expansion of .[test] works. I could sort of infer that it has something to do with the test dependencies from setup.py. Perhaps a note would help?

Eh, please feel free to ignore this. I finally figured out that where this is documented (pip and setuptools). Not knowing it was a matter of my unwillingness to learn stuff that I should have learned. :-)

@exarkun exarkun merged commit 1c6b2bb into master Aug 11, 2020
@exarkun exarkun deleted the 17.remove-pyutil-dependency branch August 11, 2020 16:18
@sajith sajith mentioned this pull request Sep 17, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants