Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group reflect user into seperate rooms #850

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"react-markdown": "^9.0.0",
"react-redux": "^8.1.2",
"react-router-dom": "^5",
"reflect-orchestrator": "^0.0.2",
"rehype-external-links": "^3.0.0",
"stream": "^0.0.2",
"stream-browserify": "^3.0.0",
Expand Down
9 changes: 1 addition & 8 deletions src/shared/hooks/reflect.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { createContext, useContext, useEffect, useMemo, useState } from "react"
import {
selectDisplayedRealmId,
selectRealmNameById,
selectStakingRealmId,
selectWalletName,
Expand Down Expand Up @@ -160,7 +159,6 @@ export function useReflectCurrentUser() {
export function useReflectCursors() {
const reflectClients = useReflectPresence()
const currentUser = useReflectCurrentUser()
const realmModalOpened = useDappSelector(selectDisplayedRealmId)

// Find index of current user to determine the "room" placement
const currentUserIndex = reflectClients.findIndex(
Expand All @@ -180,15 +178,10 @@ export function useReflectCursors() {
// We want users to always have a chance to interact with each other so we split them
// into "rooms" based on their index in the reflectClients array. This way map stays interactive
// while still being not overcrowded.
const visibleClients = reflectClients.slice(
const visibleCursors = reflectClients.slice(
currentRoomValue,
currentRoomValue + maxNumberOfVisibleCursors
)

// Hide current user cursor when the realm modal is opened
const visibleCursors = !realmModalOpened
? visibleClients
: visibleClients.filter((client) => client.id !== currentUser?.id)

return { visibleCursors, currentUser }
}
10 changes: 10 additions & 0 deletions src/shared/utils/reflect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,21 @@ import {
reflectClientSchema,
} from "shared/types"
import { Schema } from "zod"
import {
OrchestrationOptions,
createOrchestrationMutators,
} from "reflect-orchestrator"

// Source: https://github.com/rocicorp/reflect-draw/blob/main/src/datamodel/zod.ts
function parseReflectState<T>(schema: Schema<T>) {
return process.env.NODE_ENV !== "production" ? schema.parse : (val: T) => val
}

// Set max room capacity to 50, still displaying 5 at one time
const orchestrationOptions: OrchestrationOptions = {
maxClientsPerRoom: 50,
}

export const {
init: initClientState,
get: getClientState,
Expand Down Expand Up @@ -57,6 +66,7 @@ export const mutators = {
setCursor,
setUserInfo,
setUserPresence,
...createOrchestrationMutators(orchestrationOptions),
}

export type ReflectMutators = typeof mutators
Expand Down
16 changes: 7 additions & 9 deletions src/ui/Island/IslandPresence.tsx
Original file line number Diff line number Diff line change
@@ -1,28 +1,26 @@
import React from "react"
import { useReflectCursors } from "shared/hooks"
import { selectRealmPanelVisible, useDappSelector } from "redux-state"
import IslandCursor from "./Cursor"

export default function IslandPresence() {
const { visibleCursors, currentUser } = useReflectCursors()
const realmPanelVisible = useDappSelector(selectRealmPanelVisible)

const reflectEnabled = process.env.SHOW_REFLECT === "true"

if (
!visibleCursors ||
!visibleCursors.length ||
!currentUser ||
!reflectEnabled
)
return null
if (!visibleCursors.length || !currentUser || !reflectEnabled) return null

return visibleCursors.map(({ id, cursor, userInfo }) => {
if (!cursor) return null
const isCurrentUser = id === currentUser.id
if (!cursor || (isCurrentUser && realmPanelVisible)) return null

return (
<IslandCursor
key={id}
cursor={cursor}
userInfo={userInfo}
extraCursor={id !== currentUser.id}
extraCursor={!isCurrentUser}
/>
)
})
Expand Down
14 changes: 14 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2777,6 +2777,11 @@
resolved "https://registry.yarnpkg.com/@rocicorp/rails/-/rails-0.8.0.tgz#ee8f3826c640f1fc8cb4b8de97b952378098c052"
integrity sha512-BX/Owk5ikuLcXghQxlfPgcBWou5TWoGxktSxqUQZdCrsiP0CHEjOPJVhli4TuwRbxuzqS4MaHSeHa//PuwchGQ==

"@rocicorp/rails@^0.8.1":
version "0.8.1"
resolved "https://registry.yarnpkg.com/@rocicorp/rails/-/rails-0.8.1.tgz#f78a9017b7cd5587eecb04e5b6e74911cc52dfe9"
integrity sha512-+NwaJtKyAP0W5KK84nVqlpl03aJXsEhiQg3FZYj08jTPYYdp2zfzc8dpzXcpC8GcfFST8vgqj/fMlgNU9Zvnsw==

"@rocicorp/reflect@^0.38.202311200859":
version "0.38.202311200859"
resolved "https://registry.yarnpkg.com/@rocicorp/reflect/-/reflect-0.38.202311200859.tgz#487a0340698d22d78febb1de7a36dd6b999adf7d"
Expand Down Expand Up @@ -9404,6 +9409,15 @@ redux@^4.2.1:
dependencies:
"@babel/runtime" "^7.9.2"

reflect-orchestrator@^0.0.2:
version "0.0.2"
resolved "https://registry.yarnpkg.com/reflect-orchestrator/-/reflect-orchestrator-0.0.2.tgz#6a50f45e1187514ee44d112cdb7d436cf4a058bc"
integrity sha512-5BgNFIkvbUIWh3r9iYx1qjJ/rBKMwpTS7ZYES/CPunQhm2nSgAl8Zrm/DZPVFFIpnVTgixsumql6Tq9gCwr8Uw==
dependencies:
"@badrap/valita" "^0.3.0"
"@rocicorp/rails" "^0.8.1"
"@rocicorp/reflect" "^0.38.202311200859"

reflect.getprototypeof@^1.0.3:
version "1.0.3"
resolved "https://registry.yarnpkg.com/reflect.getprototypeof/-/reflect.getprototypeof-1.0.3.tgz#2738fd896fcc3477ffbd4190b40c2458026b6928"
Expand Down