Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote devtools to @redux-devtools packages #1416

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

Shadowfiend
Copy link
Contributor

@Shadowfiend Shadowfiend commented May 9, 2022

These are newer and actually maintained. This also fixes an issue with
installing the older tool on macOS due to precompiled SQLite packages
not being available for the sqlite version being referenced in the
unmaintained package.

Closes #1401 .

These are newer and actually maintained. This also fixes an issue with
installing the older tool on macOS due to precompiled SQLite packages
not being available for the sqlite version being referenced in the
unmaintained package.
@Shadowfiend Shadowfiend requested a review from a team May 9, 2022 19:21
@mhluongo
Copy link
Contributor

mhluongo commented May 9, 2022

A local yarn install looks like our webext-redux patch isn't applied after these changes

Screenshot from 2022-05-09 15-30-19

This is to deal with yarn not hoisting the dependency to top-level
node_modules even though dependency versions match. This prevents our
local webext-redux patch from taking effect.

Future work here could include bumping to Yarn v2.
@Shadowfiend
Copy link
Contributor Author

Fixed this in a hacky way. Need to poke at yarn v2 again with an eye on node-modules resolution: yarnpkg/yarn#7572 (comment)

Copy link
Contributor

@mhluongo mhluongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@mhluongo mhluongo merged commit fb28464 into main May 9, 2022
@mhluongo mhluongo deleted the remote-reduction branch May 9, 2022 20:47
@greg-nagy
Copy link
Contributor

🎉🎉 master of yaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix sqllite install issue
3 participants