Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untrusted assets should not block the addition of custom tokens #3491

Merged
merged 17 commits into from
Jul 8, 2023
Merged

Untrusted assets should not block the addition of custom tokens #3491

merged 17 commits into from
Jul 8, 2023

Commits on Jun 21, 2023

  1. Allow users to add an asset that is in the untrusted list

    Karolina Kosiorowska committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5a849ea View commit details
    Browse the repository at this point in the history

  2. Fix incorrect condition for adding a custom token

    Karolina Kosiorowska committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5f36c19 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Refactor for adding an asset from an unverified list 

    - Simplification of the update logic when an asset already exists.
- Create a function to check whether the asset is verified.
- Addition of comments.
    Karolina Kosiorowska committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    dce74a9 View commit details
    Browse the repository at this point in the history

  2. Fix checking that asset is manually imported

    Karolina Kosiorowska committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    ee820f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Add basic tests and fix issues for adding an asset

    Karolina Kosiorowska committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    12dce07 View commit details
    Browse the repository at this point in the history

  2. Fix for allow adding discovery tx hash for asset

    Karolina Kosiorowska committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    546f8c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Minor simplification of logic

    Karolina Kosiorowska committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    c83cf0e View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Simplify the condition for isVerifiedAsset

    Karolina Kosiorowska committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    7ce70ff View commit details
    Browse the repository at this point in the history

  2. Fix for incorrect conditions- unverified assets

    Karolina Kosiorowska committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5897275 View commit details
    Browse the repository at this point in the history

  3. Fix the issue for dust warning during adding token 

    When a user adds an unverified asset manually it should not bring up a dust warning. This token should be displayed in the list even is dust.
    Karolina Kosiorowska committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    c77920a View commit details
    Browse the repository at this point in the history

  4. Minor refactoring for importing unverified tokens 

    - Minor changes to the comments
- Removal of the `discoveryTxHash` refresh logic. It is no longer needed. The change was to update the `discoveryTxHash` after the data migration, where `discoveryTxHash` was removed for all custom assets. This also resulted in the wrong adding of a `discoveryTxHash` for the asset in the token list. The change solves this issue.
    Karolina Kosiorowska committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    0db9840 View commit details
    Browse the repository at this point in the history

  5. Fix issue for lint

    Karolina Kosiorowska committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    14414f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Fix the issue with a warning about dust 

    After manually adding a token from the list of unverified assets, it will be displayed normally, even though it is dust. Therefore, the dust warning should be displayed when the asset does not yet exist in the wallet.
    Karolina Kosiorowska committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    b0969f4 View commit details
    Browse the repository at this point in the history

  2. Cleaning for manual import of custom tokens

    Karolina Kosiorowska committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    b005153 View commit details
    Browse the repository at this point in the history

  3. Ignore price warnings for untrusted tokens

    Karolina Kosiorowska committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    bcc7579 View commit details
    Browse the repository at this point in the history

  4. Show price info for trusted or verified tokens

    Karolina Kosiorowska committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    760c3a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Merge branch 'main' into fix-adding-assets

    @Shadowfiend
    Shadowfiend committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    c01bef5 View commit details
    Browse the repository at this point in the history