Testing new flags #3642
Merged
Testing new flags #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set it by default to the Tenderly fork.
We use a dismissable item for the banner itself, which will be dismissed on clicking the Explore The Island link. No styling is included at the moment, and there is a stub for not displaying the banner unless the token has been detected as deployed---this part is not yet implemented.
It will be used to handle the Island game on testnet.
This was already available on the db, but unexposed.
The two env variables we add for now are for the Taho deployer and TAHO itself on testnet. We can derive the TAHO address from the deployer, but for now it will live in a constant and thus must be specified ahead of time.
These are, currently, the TAHO token as well as the realm XP tokens for each of the starting realms. Starting realms are named due to the way the deployer works, and those names are hardcoded for the testnet. Eventually we'll want to iterate these from the game contract.
References in main and the claim slice weren't fully updated, and fixing those references required rearranging where certain constants were to avoid circular dependencies. The island network has also been abstracted to a constant based on whether the Arbitrum fork is defined or not.
We achieve this by only marking the token as being tracked when it is detected as having code on-chain. The claim slice then exposes a selector that checks if the TESTNET_TAHO token is in the list of tracked island assets.
We'll want to do this with XP as well most likely, but not yet.
For some reason custom assets started being considered a source of truth for asset tracking, instead of custom assets being used strictly for asset metadata and tracked assets being used for tracking info. Anyway, now we include both and deduplicate in `mergeAssets` as usual.
Notably, rather than using a link, we use a `SharedButton`. This is because the styling is basically the same as `SharedButton`, and `SharedLink` can't currently reproduce that (bummer). It also means link opening has to be implemented via browser.tabs.create :/
This will allow these to show proper token approval screens during transaction signing.
Banned Portals: Add a skeleton for the portal Banner
A tender booyan: Tenderly test build
We've rotated the wallets used for testing of the extension and moved some of the assets. The GH secrets got already updated accordingly, we now need to update the addresses of wallets and change some other values used in tests, to fit the assets that we have on the new testing wallets. Changes include: * switching of `e2e.testertesting.eth` wallet from `0x6f1b1f1feb01235e15a7962f16c389c7f8218ed6` to `0x9d373acbe8540895fa1752ab463ab31bbab2b38f` * switching of `testertesting.eth` wallet from `0x0581470a8b62bd35dbf121a6329d43e7edd20fc7` to `0x6e80164ea60673d64d5d6228beb684a1274bb017` * changing the POAP used in the NFTs tests * changing the number of a forking block (the new testing wallet didn't have any assets yet on an old forking block) and switching to a different asset used in tests of ERC-20 transfers.
Island QA build fixes
Update e2e tests after change of testing accounts
Resolves tahowallet/dapp#348 Resolves tahowallet/dapp#317 Fixing a bunch of problems with the banner and fetching balances of TAHO ### Testing - [x] TAHO balance should be visible quickly (expect normal speed of discovery for an ERC20 token) - [x] banner should be visible only for accounts that have TAHO but on all networks, regardless if Arb Sepolia was ever visited - [x] banner should be visible for all account types - read only, ledger, keys and mnemonics - [x] banner should be visible for an account with TAHO then it is added as a first account to the wallet, as another account and after user removes and adds account again - [x] banner should be never visible again after it is closed ## Testing Environment ``` SUPPORT_THE_ISLAND=true SUPPORT_THE_ISLAND_ON_TENDERLY=true ``` Latest build: [extension-builds-263](https://github.com/tahowallet/tally-extension-token/suites/17282826993/artifacts/987399863) (as of Mon, 16 Oct 2023 16:40:05 GMT).
Without setting the network correctly, the banner may not appear correctly as testnet Taho is not necessarily considered deployed depending on contract address drift.
… display on Tenderly fork (#264) Feeling pretty confident about setting `ISLAND_NETWORK` based on env variable but please correct me if I'm imagining things. <img width="423" alt="Screenshot 2023-10-16 at 22 22 35" src="https://github.com/tahowallet/tally-extension-token/assets/8245/3624a3dc-c8cb-4fb0-91c0-35e7c42d5737"> Also set the final dApp URL after checking in with @mr-michael . Latest build: [extension-builds-264](https://github.com/tahowallet/tally-extension-token/suites/17300266372/artifacts/988387326) (as of Tue, 17 Oct 2023 02:44:20 GMT).
If user has no TAHO then let's display this banner:  ## Testing Environment ``` SUPPORT_THE_ISLAND=true SUPPORT_THE_ISLAND_ON_TENDERLY=true ``` Latest build: [extension-builds-265](https://github.com/tahowallet/tally-extension-token/suites/17312286568/artifacts/989127738) (as of Tue, 17 Oct 2023 10:15:45 GMT).
Reverting the change as it chain ids were not matched elsewhere and it wasn't working. Having Arbitrum One as a base for fork on Tenderly is not causing problems even if wallet thinks it is working on Arb Sepolia.
Resolves tahowallet/dapp#391 Resolves #269 - allow to dismiss both banners - fix problems with dismissing only one of them - update copy  Latest build: [extension-builds-268](https://github.com/tahowallet/tally-extension-token/suites/17349665773/artifacts/991403761) (as of Wed, 18 Oct 2023 07:00:28 GMT).
Resolves tahowallet/dapp#170 Change flags to support new features⚠️ This is already working on live version on Arb Sepolia Latest build: [extension-builds-270](https://github.com/tahowallet/tally-extension-token/suites/17350510366/artifacts/991469355) (as of Wed, 18 Oct 2023 07:39:33 GMT).
kkosiorowska
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest build: extension-builds-3642 (as of Wed, 18 Oct 2023 10:09:14 GMT).