-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support video avatars #3700
Merged
Merged
Support video avatars #3700
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
242cd84
Create reusable `SharedAvatar` component
xpaczka 6f464e6
Move avatar type fetching to redux
xpaczka ccb4679
Resize avatar image
xpaczka a4feb8e
Merge branch 'main' into video-avatar
xpaczka b3d30f5
Upgrade redux migration to v36
xpaczka c74eabf
Remove latest `redux` migration
xpaczka 2cca702
Move fetching avatar type from `redux` to component
xpaczka 58d05ab
Merge branch 'main' into video-avatar
jagodarybacka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
import React, { CSSProperties } from "react" | ||
|
||
type SharedAvatarProps = { | ||
width: string | ||
background?: string | ||
borderRadius?: string | ||
avatarURL?: string | ||
avatarType?: string | ||
backupAvatar: string | ||
style?: CSSProperties | ||
} | ||
|
||
export default function SharedAvatar({ | ||
width, | ||
background = "var(--green-40)", | ||
borderRadius = "12px", | ||
avatarURL, | ||
avatarType, | ||
backupAvatar, | ||
style, | ||
}: SharedAvatarProps) { | ||
return ( | ||
<> | ||
{avatarType === "video/mp4" ? ( | ||
<div className="video" style={style}> | ||
<video src={avatarURL} autoPlay muted loop /> | ||
</div> | ||
) : ( | ||
<div className="avatar" style={style} /> | ||
)} | ||
<style jsx>{` | ||
.avatar { | ||
width: ${width}; | ||
height: ${width}; | ||
border-radius: ${borderRadius}; | ||
flex-shrink: 0; | ||
background-color: ${background}; | ||
background: url("${avatarURL ?? backupAvatar}"); | ||
background-size: cover; | ||
background-position: center; | ||
background-repeat: no-repeat; | ||
} | ||
.video { | ||
width: ${width}; | ||
height: ${width}; | ||
border-radius: ${borderRadius}; | ||
background-color: ${background}; | ||
overflow: hidden; | ||
} | ||
.video > video { | ||
width: 100%; | ||
height: 100%; | ||
object-fit: cover; | ||
} | ||
`}</style> | ||
</> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: This is changing shape of the redux and in the extension we are persisting redux state between reloads. Usually we are adding redux migration but in this case I think we are fine because we are ok with this field being
undefined
. Anyway - I'll test the migration to make sure it is ok.EDIT:
ok so we will need a migration unfortunately
Reproduction steps:
main
result: no avatar at all, not even the light green background
expected: there is a video avatar visible