Refactor2023: Remove IRNode::get_config and IRNode::get_kernel

taichi-dev · Dec 7, 2022 · 592f798 · 592f798
1 parent 19d6e11
commit 592f798
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 29 deletions.
diff --git a/taichi/codegen/codegen.cpp b/taichi/codegen/codegen.cpp
@@ -113,10 +113,9 @@ LLVMCompiledKernel KernelCodeGen::compile_kernel_to_module() {
   using TaskFunc = int32 (*)(void *);
   std::vector<TaskFunc> task_funcs(offloads.size());
   for (int i = 0; i < offloads.size(); i++) {
-    auto compile_func = [&, i] {
+    auto compile_func = [&, kernel = this->kernel, i] {
       tlctx->fetch_this_thread_struct_module();
-      auto offload =
-          irpass::analysis::clone(offloads[i].get(), offloads[i]->get_kernel());
+      auto offload = irpass::analysis::clone(offloads[i].get(), kernel);
       irpass::re_id(offload.get());
       auto new_data =
           this->compile_task(&config, nullptr, offload->as<OffloadedStmt>());

diff --git a/taichi/codegen/dx12/codegen_dx12.cpp b/taichi/codegen/dx12/codegen_dx12.cpp
@@ -232,8 +232,7 @@ KernelCodeGenDX12::CompileResult KernelCodeGenDX12::compile() {
 
   CompileResult Result;
   for (int i = 0; i < offloads.size(); i++) {
-    auto offload =
-        irpass::analysis::clone(offloads[i].get(), offloads[i]->get_kernel());
+    auto offload = irpass::analysis::clone(offloads[i].get(), kernel);
     irpass::re_id(offload.get());
     auto *offload_stmt = offload->as<OffloadedStmt>();
     auto new_data = compile_task(&config, nullptr, offload_stmt);

diff --git a/taichi/ir/ir.h b/taichi/ir/ir.h
@@ -206,12 +206,9 @@ class IRNode {
   virtual IRNode *get_parent() const = 0;
 
   IRNode *get_ir_root();
-  Kernel *get_kernel() const;
 
   virtual ~IRNode() = default;
 
-  CompileConfig &get_config() const;
-
   template <typename T>
   bool is() const {
     return dynamic_cast<const T *>(this) != nullptr;

diff --git a/taichi/program/ir_node_extended_impl.cpp b/taichi/program/ir_node_extended_impl.cpp
diff --git a/taichi/transforms/compile_to_offloads.cpp b/taichi/transforms/compile_to_offloads.cpp
@@ -251,7 +251,7 @@ void offload_to_executable(IRNode *ir,
   irpass::analysis::verify(ir);
 
   if (is_extension_supported(config.arch, Extension::quant) &&
-      ir->get_config().quant_opt_atomic_demotion) {
+      config.quant_opt_atomic_demotion) {
     irpass::analysis::gather_uniquely_accessed_bit_structs(ir, amgr.get());
   }