Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ti.append only support i32. #3337

Closed
FantasyVR opened this issue Nov 1, 2021 · 6 comments
Closed

ti.append only support i32. #3337

FantasyVR opened this issue Nov 1, 2021 · 6 comments
Assignees
Labels
feature request Suggest an idea on this project medium Medium level difficulty, give it a shot :-) welcome contribution

Comments

@FantasyVR
Copy link
Collaborator

Concisely describe the proposed feature

The user in the forum wants to use ti.append with float data type. Forum link

However, Taichi doesn't support that according to here.

Should we support more data types?

@FantasyVR FantasyVR added the feature request Suggest an idea on this project label Nov 1, 2021
@k-ye
Copy link
Member

k-ye commented Nov 1, 2021

+1. Let's support f32 as a start :-)

@k-ye k-ye added welcome contribution medium Medium level difficulty, give it a shot :-) labels Nov 1, 2021
@FantasyVR FantasyVR self-assigned this Nov 1, 2021
@FantasyVR
Copy link
Collaborator Author

@k-ye Do you have some ideas about how to implement this feature?

Now, a hack solution is that I could simply change the signature of function Dynamic_append:

i32 Dynamic_append(Ptr meta_, Ptr node_, i32 data) {

as

i32 Dynamic_append(Ptr meta_, Ptr node_, f32 data) {

@WenheLI
Copy link

WenheLI commented Nov 1, 2021

It seems like we need to wrap the above function signature with a template to allow it?

@k-ye
Copy link
Member

k-ye commented Nov 1, 2021

Templatizing this SGTM! Feel free to take this over, you likely need to spend some time dealing with template functions in LLVM :-) @WenheLI

@FantasyVR FantasyVR assigned WenheLI and unassigned FantasyVR Nov 1, 2021
@FantasyVR
Copy link
Collaborator Author

Hi @WenheLI, sorry to bother you. Is there any progress on this issue?

@WenheLI
Copy link

WenheLI commented Dec 1, 2021

Still looking into the solution. Will keep you posted once find anything!
Sorry for the late reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggest an idea on this project medium Medium level difficulty, give it a shot :-) welcome contribution
Projects
None yet
Development

No branches or pull requests

3 participants