Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply file lock before wrting offline cache to file #5385

Closed
jim19930609 opened this issue Jul 11, 2022 · 1 comment
Closed

Apply file lock before wrting offline cache to file #5385

jim19930609 opened this issue Jul 11, 2022 · 1 comment
Assignees
@jim19930609 @lin-hitonami
Labels
potential bug Something that looks like a bug but not yet confirmed

Comments

@jim19930609
Copy link
Contributor

jim19930609 commented Jul 11, 2022 •
edited
Loading

File lock is missing in the current implementation of file serializer. When running two or more Taichi programs simultaneously, this is gonna cause trouble in the following manner:

  1. Mess up the metadata.* files, which are shared across kernels, fields (and processes of course).
  2. Two or more standalone applications running the same kernel (helper kernels, kernel library, etc)

2022-07-11 11-35-48 的屏幕截图
@jim19930609 jim19930609 added the potential bug Something that looks like a bug but not yet confirmed label Jul 11, 2022
@lin-hitonami
Copy link
Contributor

Fixed in #5578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jim19930609 jim19930609

@lin-hitonami lin-hitonami

Labels
potential bug Something that looks like a bug but not yet confirmed
Projects
Taichi Lang
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jim19930609 @lin-hitonami