Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a ' f32 <- f64' waring in copy_colors_to_vbo #5424

Closed
EnochZhu opened this issue Jul 14, 2022 · 0 comments
Closed

a ' f32 <- f64' waring in copy_colors_to_vbo #5424

EnochZhu opened this issue Jul 14, 2022 · 0 comments
Assignees
@feisuzhu
Labels
potential bug Something that looks like a bug but not yet confirmed

Comments

@EnochZhu
Copy link

When I used ggui to draw circles,an warning came up.
Global store may lose precision: f32 <- f64On line 38 of file "...\taichi\ui\staging_buffer.py", in fill_vbo: vbo[i][offset + c] = value
It seems due to the default float I used is f64 so that the 1.0 in fill_vbo(vbo, 1.0, 11, 1) is aranged in f64.I suggset use fill_vbo(vbo, ti.cast(1.0, ti.f32), 11, 1) (at line 78,staging_buffer.py,v1.04) instead.
@EnochZhu EnochZhu added the potential bug Something that looks like a bug but not yet confirmed label Jul 14, 2022
@feisuzhu feisuzhu self-assigned this Jul 22, 2022
feisuzhu added a commit to feisuzhu/taichi that referenced this issue Jul 26, 2022
@feisuzhu
[misc] Fix warning at GGUI canvas.circles (taichi-dev#5424)
54eb530
@feisuzhu feisuzhu mentioned this issue Jul 26, 2022
Merged
ailzhang pushed a commit that referenced this issue Jul 26, 2022
@feisuzhu
[misc] Fix warning at GGUI canvas.circles (#5424) (#5518)
811bff8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feisuzhu feisuzhu

Labels
potential bug Something that looks like a bug but not yet confirmed
Projects
Taichi Lang
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feisuzhu @EnochZhu