Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Fix import warnings when using collections module #1084

Merged
merged 1 commit into from May 30, 2020
Merged

[misc] Fix import warnings when using collections module #1084

merged 1 commit into from May 30, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented May 30, 2020 •
edited by archibate

@k-ye k-ye requested a review from yuanming-hu May 30, 2020 01:41
yuanming-hu
yuanming-hu approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

archibate
archibate approved these changes May 30, 2020
View reviewed changes
Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GR8, but I was intended to left this issue for beginners, see #1057, anyway, thank for fixing this.

@k-ye k-ye merged commit 9daa033 into taichi-dev:master May 30, 2020
@k-ye k-ye deleted the warn branch May 30, 2020 05:52
@yuanming-hu yuanming-hu mentioned this pull request May 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

@archibate archibate archibate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] fix python "deprecated" warnings in test
3 participants
@k-ye @yuanming-hu @archibate