Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Let pytest-rerunfailures pytest-xdist to be hard dependences #1187

Merged
merged 3 commits into from
Jun 9, 2020
Merged

[test] Let pytest-rerunfailures pytest-xdist to be hard dependences #1187

merged 3 commits into from
Jun 9, 2020

Conversation

archibate
Copy link
Collaborator

Related issue = (reported by GAMES 201 students)

[Click here for the format server]

@archibate archibate changed the title [test] Make pytest-rerunfailures pytest-xdist as hard dependences [test] Let pytest-rerunfailures pytest-xdist to be hard dependences Jun 8, 2020
@archibate archibate requested a review from xumingkuan June 8, 2020 05:42
rexwangcc
rexwangcc approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, finally we could get rid of the 2 confusing plugin probes.

xumingkuan
xumingkuan approved these changes Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rexwangcc
Copy link
Member

Btw, maybe we could remove the misc/empty_pytest.py now since we don't need to use them for plugin probes?

@archibate archibate added the LGTM label Jun 9, 2020
@archibate archibate merged commit 4dcc638 into taichi-dev:master Jun 9, 2020
@yuanming-hu yuanming-hu mentioned this pull request Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexwangcc rexwangcc rexwangcc approved these changes

@xumingkuan xumingkuan xumingkuan approved these changes

@yuanming-hu yuanming-hu Awaiting requested review from yuanming-hu

@k-ye k-ye Awaiting requested review from k-ye

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@archibate @rexwangcc @xumingkuan @taichi-gardener